Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming parameter views of repeated charts + interactivity #3024

Closed
mattijn opened this issue Apr 17, 2023 · 4 comments
Closed

naming parameter views of repeated charts + interactivity #3024

mattijn opened this issue Apr 17, 2023 · 4 comments
Labels

Comments

@mattijn
Copy link
Contributor

mattijn commented Apr 17, 2023

I was re-reading this comment vega/vega-lite#8446 (comment), but I'm not able to get

  • repeat charts + interactivity

to work anymore.

The following views definition: <view-name>child__<repeat-row>_<data-field><repeat-column>_<data-field> does not give interactivity in the charts with VL5.7.

See also this example where the interactivity (here zooming through "bind": "scales") does not work anymore Open the Chart in the Vega Editor

I tried a few things and inspect this PR at the VL repository, but I can't find a way how to make this work again. Any idea @domoritz?

(issue distilled from #2849)

@mattijn mattijn added the bug label Apr 17, 2023
@mattijn
Copy link
Contributor Author

mattijn commented Apr 17, 2023

Wrong repo: vega/vega-lite#8845

@mattijn mattijn closed this as completed Apr 17, 2023
@mattijn
Copy link
Contributor Author

mattijn commented Apr 23, 2023

I get the interactivity if I add a _ between the view name and child__, see this working spec. Or is this not what you wanted to achieve?

Originally posted by @binste in vega/vega-lite#8845 (comment)

@mattijn mattijn reopened this Apr 23, 2023
@mattijn
Copy link
Contributor Author

mattijn commented Apr 23, 2023

I suspect this line, https://github.com/altair-viz/altair/blob/master/altair/vegalite/v5/api.py#L3313, should include a leading _ in front of child__, return v + "_child__" + r or return '_'.join([v, 'child_', r]

@mattijn
Copy link
Contributor Author

mattijn commented Apr 24, 2023

Fixed by #3030.

@mattijn mattijn closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant