You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Altair has many files which are auto-generated based on the Vega-Lite schema. For development, it is often convenient to modify those directly but before merging into master, these changes need to be applied to the relevant scripts in the tools folder which is a step that is easy to forget.
It would be great if the tests for a PR fail if changes were applied to auto-generated files. One way could be to add a new step in build.yml which runs python tools/generate_schema_wrapper.py and then checks if any files were changed with git ls-files --modified.
The text was updated successfully, but these errors were encountered:
Altair has many files which are auto-generated based on the Vega-Lite schema. For development, it is often convenient to modify those directly but before merging into master, these changes need to be applied to the relevant scripts in the
tools
folder which is a step that is easy to forget.It would be great if the tests for a PR fail if changes were applied to auto-generated files. One way could be to add a new step in build.yml which runs
python tools/generate_schema_wrapper.py
and then checks if any files were changed withgit ls-files --modified
.The text was updated successfully, but these errors were encountered: