Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR tests should fail if generate_schema_wrapper produces changes #2906

Closed
binste opened this issue Feb 20, 2023 · 2 comments · Fixed by #2940
Closed

PR tests should fail if generate_schema_wrapper produces changes #2906

binste opened this issue Feb 20, 2023 · 2 comments · Fixed by #2940

Comments

@binste
Copy link
Contributor

binste commented Feb 20, 2023

Altair has many files which are auto-generated based on the Vega-Lite schema. For development, it is often convenient to modify those directly but before merging into master, these changes need to be applied to the relevant scripts in the tools folder which is a step that is easy to forget.

It would be great if the tests for a PR fail if changes were applied to auto-generated files. One way could be to add a new step in build.yml which runs python tools/generate_schema_wrapper.py and then checks if any files were changed with git ls-files --modified.

@joelostblom
Copy link
Contributor

This sounds like a good idea and will make it easier to keep track of which files need changes.

@binste
Copy link
Contributor Author

binste commented Feb 25, 2023

Great, I will create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants