Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all new VegaLite functionality since 4.17 #2703

Closed
joelostblom opened this issue Oct 26, 2022 · 3 comments
Closed

Add tests for all new VegaLite functionality since 4.17 #2703

joelostblom opened this issue Oct 26, 2022 · 3 comments

Comments

@joelostblom
Copy link
Contributor

This is a reminder to make sure we add tests/gallery examples of the new features introduced since Vega-Lite 4.17.

@ChristopherDavisUCI
Copy link
Contributor

I got started on the parameter side of this in #2828.

Also #2811 checked that certain layer properties got moved to the top level. (This isn't a big feature, but it caused many tests to break during the initial transition to Vega-Lite 5.)

@ChristopherDavisUCI
Copy link
Contributor

I went through the the release notes up to Vega-Lite v5.2.0 and I didn't notice anything else major that needed a corresponding test. (Reminder to myself: A few offset charts have already been added to the example gallery, like Strip Plot with Jitter and Grouped Bar Chart with xOffset. I tried to link the corresponding files, but I can't find the gallery on GitHub? I'm sure I'm missing something obvious.)

If you see anything else where a test should be added, please let me know and I can work on it!

@joelostblom
Copy link
Contributor Author

Great, thank you! I will close this as it was implemented in #2828 then.

Regarding the gallery, I believe all the examples were moved in the to new test directory here https://github.com/altair-viz/altair/tree/master/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants