Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parse_ruby_hash): drop initial colon in key parsing #1050

Merged
merged 5 commits into from
Sep 25, 2024
Merged

fix(parse_ruby_hash): drop initial colon in key parsing #1050

merged 5 commits into from
Sep 25, 2024

Conversation

tessneau
Copy link
Contributor

@tessneau tessneau commented Sep 24, 2024 •
edited
Loading

This makes a fix to the parse_ruby_hash parser to align more with the Datadog implementation. Specifically if there's a colon within the key, the parser will drop it instead of retaining it as before.

@tessneau tessneau changed the title enhancement(ruby_hash parser): drop initial colon in key parsing fix(ruby_hash parser): drop initial colon in key parsing Sep 24, 2024
@tessneau tessneau marked this pull request as ready for review September 24, 2024 21:41
@tessneau tessneau changed the title fix(ruby_hash parser): drop initial colon in key parsing fix(parse_ruby_hash): drop initial colon in key parsing Sep 24, 2024
@tessneau tessneau added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 30296eb Sep 25, 2024
14 checks passed
@tessneau tessneau deleted the tess.neau/fix-rubyhash-parser-colon-in-keys branch September 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tessneau @bruceg