Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial auto-updater #60

Closed
wants to merge 5 commits into from
Closed

Conversation

JamieMagee
Copy link

A first pass at automatically updating package versions. Heavily inspired by https://github.com/vcpkgx/vcpkgx.github.io.

I know that the frontend will need to be updated to deal with this new format, but I wanted to get some feedback before I went too far in on this.

Closes #21

@JamieMagee JamieMagee marked this pull request as ready for review November 10, 2021 02:54
@dan-shaw
Copy link
Contributor

Thanks for the PR! This makes a lot of sense. I am in favor of deprecating the Powershell scripts. I think there are two results missing from output.json (the CI baseline results and repository stars), which are used for the package search on the website. Not sure what the best way is to get repository stars from a workflow

Currently output.json is not an official API of course, though we will be adding new APIs to the website (for our IDE integration effort). Since we are going to be publishing other APIs, it makes sense to make this API official as well. Let me get back to you on this issue.

@JamieMagee
Copy link
Author

@dan-shaw Thanks for the feedback. I am a Microsoft FTE, so feel free to reach out to me internally as well (though this effort is designed to help vcpkg support in another open-source project Renovate).

Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other thing I see - what about "Stars"?

scripts/update/index.ts Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

Related to #48

@JamieMagee
Copy link
Author

Updated this PR with support for stars. Will follow-up with a PR for CI baseline1

Footnotes

  1. https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt

@JamieMagee JamieMagee requested a review from strega-nil-ms July 3, 2022 06:22
@JamieMagee
Copy link
Author

Added support for baseline parsing. Here's a sample output.json

@JamieMagee
Copy link
Author

@dan-shaw Is there anyone available to review this?

@chausner
Copy link

Any status update on this?

@JavierMatosD
Copy link
Collaborator

Thank you for contributing this pull request to add auto-update functionality. I apologize for the delay in addressing this.

We have since implemented other automation and, due to evolving security policies and plans to move this automation elsewhere, we won't be able to integrate this directly.

We appreciate your contribution and hope you continue sharing your ideas in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep package list up-to-date
6 participants