From 41bd04af3dd63300511064479577b3c902f75963 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Chapoton?= Date: Wed, 14 Feb 2024 16:48:20 +0100 Subject: [PATCH 1/2] remove some old deprecations in functional.py --- src/sage/misc/functional.py | 63 ++----------------------------------- 1 file changed, 3 insertions(+), 60 deletions(-) diff --git a/src/sage/misc/functional.py b/src/sage/misc/functional.py index 11d11dc291c..8d115685f49 100644 --- a/src/sage/misc/functional.py +++ b/src/sage/misc/functional.py @@ -23,7 +23,6 @@ import math from sage.misc.lazy_import import lazy_import -from sage.misc.superseded import deprecation lazy_import('sage.rings.complex_double', 'CDF') lazy_import('sage.rings.real_double', ['RDF', 'RealDoubleElement']) @@ -589,11 +588,10 @@ def symbolic_sum(expression, *args, **kwds): """ if hasattr(expression, 'sum'): return expression.sum(*args, **kwds) - elif max(len(args),len(kwds)) <= 1: + if max(len(args), len(kwds)) <= 1: return sum(expression, *args, **kwds) - else: - from sage.symbolic.ring import SR - return SR(expression).sum(*args, **kwds) + from sage.symbolic.ring import SR + return SR(expression).sum(*args, **kwds) def symbolic_prod(expression, *args, **kwds): @@ -848,22 +846,6 @@ def xinterval(a, b): return range(a, b + 1) -def is_commutative(x): - """ - Return whether or not ``x`` is commutative. - - EXAMPLES:: - - sage: R = PolynomialRing(QQ, 'x') - sage: is_commutative(R) - doctest:...DeprecationWarning: use X.is_commutative() or X in Rings().Commutative() - See https://github.com/sagemath/sage/issues/32347 for details. - True - """ - deprecation(32347, "use X.is_commutative() or X in Rings().Commutative()") - return x.is_commutative() - - def is_even(x): """ Return whether or not an integer ``x`` is even, e.g., divisible by 2. @@ -883,45 +865,6 @@ def is_even(x): return x % 2 == 0 -def is_integrally_closed(x): - """ - Return whether ``x`` is integrally closed. - - EXAMPLES:: - - sage: is_integrally_closed(QQ) - doctest:...DeprecationWarning: use X.is_integrally_closed() - See https://github.com/sagemath/sage/issues/32347 for details. - True - sage: x = polygen(ZZ, 'x') - sage: K. = NumberField(x^2 + 189*x + 394) # needs sage.rings.number_field - sage: R = K.order(2*a) # needs sage.rings.number_field - sage: is_integrally_closed(R) # needs sage.rings.number_field - False - """ - deprecation(32347, "use X.is_integrally_closed()") - return x.is_integrally_closed() - - -def is_field(x, proof=True): - """ - Return whether or not ``x`` is a field. - - Alternatively, one can use ``x in Fields()``. - - EXAMPLES:: - - sage: R = PolynomialRing(QQ, 'x') - sage: F = FractionField(R) - sage: is_field(F) - doctest:...DeprecationWarning: use X.is_field() or X in Fields() - See https://github.com/sagemath/sage/issues/32347 for details. - True - """ - deprecation(32347, "use X.is_field() or X in Fields()") - return x.is_field(proof=proof) - - def is_odd(x): """ Return whether or not ``x`` is odd. From b0037ce75af1dc74007002b005fa8842a4dabd3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Chapoton?= Date: Thu, 15 Feb 2024 08:47:28 +0100 Subject: [PATCH 2/2] remove imports --- src/sage/misc/all.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sage/misc/all.py b/src/sage/misc/all.py index 5876ef9484d..8aee092368c 100644 --- a/src/sage/misc/all.py +++ b/src/sage/misc/all.py @@ -85,10 +85,7 @@ integral_closure, interval, xinterval, - is_commutative, is_even, - is_integrally_closed, - is_field, is_odd, kernel, krull_dimension,