Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated SoS conda packages #1544

Closed
gaow opened this issue Apr 10, 2024 · 13 comments
Closed

Outdated SoS conda packages #1544

gaow opened this issue Apr 10, 2024 · 13 comments

Comments

@gaow
Copy link
Member

gaow commented Apr 10, 2024

Here is the list of outdated packages on conda-forge that we would need to fix, comparing pypi vs conda-forge:

@gaow
Copy link
Member Author

gaow commented Apr 11, 2024

Just to let you know that we are taking a look into this with help from @danielnachun, hopefully pushing a fix soon.

@danielnachun
Copy link

An important update here - many of the feedstocks are out of date because the issue with ipkernel.tests identified in vatlab/sos-notebook#354. As of now I believe the follow conda-forge feedstocks are affected:

  • sos-bash
  • sos-julia
  • sos-matlab
  • sos-notebook
  • sos-python
  • sos-r

Of the remaining outdated feedstocks:

  • sos-rmarkdown and sos-pbs have no apparent issues and I'll rerender those
  • markdown-kernel has a linting issue with its recipe which I will fix in the update PR.
  • jupyterlab-transient-display-data had some missing dependencies and an issue with its source URL, which I will push a fix for.
  • jupyterlab-sos had some missing dependencies and an issue with properly installing its extension, as discussed here: JupyterLab SoS kernel missing right panel kernel selections jupyterlab-sos#72. See that issue for more details on the fixes.

@BoPeng
Copy link
Contributor

BoPeng commented Apr 13, 2024

For the kernels, maybe we can comment out the tests and check only if the modules can be imported.

@gaow
Copy link
Member Author

gaow commented Apr 13, 2024

Okay we'll do that and send in PR

@danielnachun
Copy link

@BoPeng I think all the kernel recipes already have an import check. For most of them we'll just end up deleting the run_test.py file from the feedstock as its only purpose is to run that unit test. I believe the only exception to this is sos-notebook which has some other test in that script, so I'll just delete the part that needs ipykernel.test.

@danielnachun
Copy link

@BoPeng I have made the PRs to address all but one feedstock. Can you merge the following PRs:

I will create a separate set of PRs after these are merged to add myself as a feedstock maintainer, because right now the CI would fail for most of the feedstocks.

The only remaining issue now is I don't see a version 0.20.9 of sos-pbs on PyPI - the newest version is 0.20.8, the same as in conda-forge. If a version 0.20.9 does exist, it will need to be uploaded to PyPI before we can update in conda-forge. Otherwise if 0.20.8 is newest version we'll just want to get auto-merge enabled, which I will make a new PR for.

@BoPeng
Copy link
Contributor

BoPeng commented Apr 14, 2024

Thanks. I have merged the PRs and released sos-pbs 0.20.9. It contains a few bug fixes that I am not sure if it is the fault of sos-pbs or my local configuration, but I made the release anyway.

@danielnachun
Copy link

Thank you so much! I made a PR for sos-pbs 0.20.9 - can you merge it as well: conda-forge/sos-pbs-feedstock#14.

The only remaining question brought up by @gaow was the version of jupyterlab-transient-display-data. The latest version on PyPI is 0.4.4, but @gaow mentioned seeing version 0.5.3 in commit messages. Is there a plan to release a new version on PyPI. Now that we have auto-merge enabled for the feedstock, it should update itself automatically after a new PyPI release.

@gaow
Copy link
Member Author

gaow commented Apr 14, 2024

Thanks! To clarify, we should not have arch specific release for these packages right? Still here for example: https://anaconda.org/conda-forge/sos-notebook I see the noarch is up to date but there are arch specific releases.

@BoPeng
Copy link
Contributor

BoPeng commented Apr 15, 2024

Regarding transient-display-data, a commit message for the release of version 0.4.3 has a tupo for version 0.5.3. Then version 0.4.4 for Jlab 4.x was released without an explicit "release" message. The current pypi (and conda) release of
0.4.4 should work.

@danielnachun
Copy link

Thanks! To clarify, we should not have arch specific release for these packages right? Still here for example: https://anaconda.org/conda-forge/sos-notebook I see the noarch is up to date but there are arch specific releases.

Both conda-forge and bioconda don't allow the deletion of old packages unless they contain malicious code or constitute license violations. So the arch-specific packages won't disappear, but won't be updated anymore. They can just be ignored - the only time they'd be an issue is if the user wanted to use the old version that was still arch specific on a platform that didn't support it, and I don't think for this type of software someone is going to need to do that.

@danielnachun
Copy link

Regarding transient-display-data, a commit message for the release of version 0.4.3 has a tupo for version 0.5.3. Then version 0.4.4 for Jlab 4.x was released without an explicit "release" message. The current pypi (and conda) release of 0.4.4 should work.

Thanks @BoPeng for clarifying this, in that case we are good to go for transient-display-data. All of the outdated conda-forge packages are now fully up to date with what is on PyPI, so I think we can close this issue. I am going to open a separate set of PRs tomorrow to add myself as a feedstock maintainer for these feedstocks, but that won't have any affect on the packages. Once those PRs are merged, I'll be able to merge another set to add @gaow as a maintainer and then the 3 of us will all be to help maintain the feedstocks for the foreseeable future.

@BoPeng
Copy link
Contributor

BoPeng commented Apr 15, 2024

Thanks for taking care of this mess.

@BoPeng BoPeng closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants