Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of -q to none (None) #1288

Closed
BoPeng opened this issue Aug 21, 2019 · 2 comments
Closed

Change default value of -q to none (None) #1288

BoPeng opened this issue Aug 21, 2019 · 2 comments
Assignees

Comments

@BoPeng
Copy link
Contributor

BoPeng commented Aug 21, 2019

Currently we have a somewhat confusing default value for -q, basically,

  1. If left unspecified, we use localhost as the default queue, which is by default a process queue but can be PBS queue as well.
  2. If we set -q none, the tasks are handled as part of substep and no queue is used.
  3. if we set -q host, we use host, and -q localhost is allowed.
  4. Under a cluster environment, we say the default is -q none.

Because unspecified -q is usually understood as -q None, the selection of default value seems to be confusing. It would perhaps make more sense to

  1. If -q is unspecified, namely if a None queue is specified, we disregard task keyword.
  2. For the use of any queue, even localhost, -q is needed. This is the point of change where -q localhost will be needed for all our examples that use localhost.

I feel that this is more consistent and we do not need to have different default behavior for cluster and non-cluster environments.

BoPeng pushed a commit that referenced this issue Aug 21, 2019
BoPeng pushed a commit that referenced this issue Aug 21, 2019
@BoPeng
Copy link
Contributor Author

BoPeng commented Aug 22, 2019

Another side effect is that in SoS Notebook, workflow with task will have to be executed with %run -q localhost, or task: queue='localhost'.

BoPeng pushed a commit that referenced this issue Aug 22, 2019
BoPeng pushed a commit to vatlab/sos-notebook that referenced this issue Aug 22, 2019
BoPeng pushed a commit to vatlab/sos-notebook that referenced this issue Aug 22, 2019
@BoPeng
Copy link
Contributor Author

BoPeng commented Aug 23, 2019

@gaow I have released sos 0.19.15 with this change. Note that this change is backward incompatible but you should be fine because you mostly use -q explicitly.

@BoPeng BoPeng closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants