Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding future plans #4

Merged
merged 1 commit into from
Feb 28, 2024
Merged

docs: adding future plans #4

merged 1 commit into from
Feb 28, 2024

Conversation

holtgrewe
Copy link
Contributor

No description provided.


Python Type Annotations
We should modernize the codebase by comprehensive use of Python type annotations.
Notable, this will require type annotations for sodar-core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have mypy in our CI? Otherwise maybe mention that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that goes without saying. Actually, pyright is the cool new engine to use ;-)

Copy link
Contributor

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should modernize the codebase by comprehensive use of Python type annotations.
Notable, this will require type annotations for sodar-core.

Backing Server Protobuf Migration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The back backend services are introduced as backing in the architecture.

@holtgrewe holtgrewe marked this pull request as ready for review February 28, 2024 13:47
@holtgrewe holtgrewe merged commit 171efc2 into main Feb 28, 2024
3 checks passed
@holtgrewe holtgrewe deleted the docs-future-plans branch February 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants