Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full test coverage on IOptionSettlementEngine with fuzzing #23

Closed
0xAlcibiades opened this issue Mar 26, 2022 · 5 comments
Closed

Full test coverage on IOptionSettlementEngine with fuzzing #23

0xAlcibiades opened this issue Mar 26, 2022 · 5 comments
Assignees
@cranium7811 @0xAlcibiades
Labels
enhancement New feature or request
Milestone
Valorem MVP

Comments

@0xAlcibiades
Copy link
Member

The requirement is to use IOptionSettlementEngine and IERC1155, ignoring the internals of the OptionSettlementEngine, to black box test the settlement layer.
@0xAlcibiades 0xAlcibiades changed the title Rehash tests for new interface Full test coverage on IOptionSettlementEngine with fuzzing Mar 27, 2022
@0xAlcibiades 0xAlcibiades self-assigned this Mar 27, 2022
@0xAlcibiades
Copy link
Member Author

We can co-work here to get the tests back in place with the new interface.

@cranium7811
Copy link
Contributor

I'm almost done with all the tests. will push it in sometime.

@0xAlcibiades
Copy link
Member Author

Some of this was addressed in #27, but need to examine and see if we have full coverage still.

@0xAlcibiades
Copy link
Member Author

I still need to go through line by line and check coverage, but it's looking pretty good now.

@0xAlcibiades 0xAlcibiades added the enhancement New feature or request label Jun 1, 2022
@0xAlcibiades 0xAlcibiades added this to the MVP milestone Jun 1, 2022
@0xAlcibiades
Copy link
Member Author

The coverage here is actually already at 100% according to foundry/forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cranium7811 cranium7811

@0xAlcibiades 0xAlcibiades

Labels
enhancement New feature or request
Projects
No open projects
Valorem Protocol MVP
Status: Done
Milestone
Valorem MVP
Development

No branches or pull requests
2 participants
@cranium7811 @0xAlcibiades