feat(popover & tooltip): add container classes #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2190 +/- ##
===============================================
+ Coverage 87.05% 87.22% +0.16%
===============================================
Files 85 85
Lines 2271 2285 +14
Branches 293 297 +4
===============================================
+ Hits 1977 1993 +16
+ Misses 191 190 -1
+ Partials 103 102 -1
Continue to review full report at Codecov.
|
|
Tested, looks good |
valorkin
requested changes
Jul 18, 2017
| @@ -0,0 +1,5 @@ | |||
| <button type="button" class="btn btn-primary" | |||
| popover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." [containerClass]="'customClass'"> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -68,5 +70,9 @@ export const DEMOS = { | |||
| stylingGlobal: { | |||
| component: require('!!raw-loader?lang=typescript!./styling-global/styling-global.ts'), | |||
| html: require('!!raw-loader?lang=markup!./styling-global/styling-global.html') | |||
| }, | |||
| class: { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -0,0 +1,5 @@ | |||
| <button type="button" class="btn btn-primary" | |||
| tooltip="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." [containerClass]="'customClass'"> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to apply custom css classes to tooltip and popover
fixes #1707
fixes #1395