fix(accoridon): remove unneeded card-title class #2024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only relevant with bs4.
You can see here that the headers are bigger than their bs3 counterparts and that the titles aren't vertically centered.
This is because of the
card-title
class which adds a margin under those titles. This class is actually used wrongly here since it serves other purposes: adding a style on<h*>
elements in the panel itself (not the header). See the docs on Card Components.