Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accoridon): remove unneeded card-title class #2024

Merged
merged 1 commit into from
Jun 2, 2017
Merged

fix(accoridon): remove unneeded card-title class #2024

merged 1 commit into from
Jun 2, 2017

Conversation

7185
Copy link
Contributor

@7185 7185 commented Jun 2, 2017

This is only relevant with bs4.
You can see here that the headers are bigger than their bs3 counterparts and that the titles aren't vertically centered.
This is because of the card-title class which adds a margin under those titles. This class is actually used wrongly here since it serves other purposes: adding a style on <h*> elements in the panel itself (not the header). See the docs on Card Components.

@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #2024 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2024   +/-   ##
============================================
  Coverage        86.54%   86.54%           
============================================
  Files               85       85           
  Lines             2252     2252           
  Branches           290      290           
============================================
  Hits              1949     1949           
  Misses             203      203           
  Partials           100      100
Impacted Files Coverage Δ
src/accordion/accordion-group.component.ts 96.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab394c...35ec3e7. Read the comment docs.

@valorkin valorkin merged commit ba56e64 into valor-software:development Jun 2, 2017
@valorkin
Copy link
Member

valorkin commented Jun 2, 2017

Thanks for great explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants