From ec8ae50c1fb6c0b6977aaa0bab59d971e86439f5 Mon Sep 17 00:00:00 2001
From: VanessaTang <yuetan@amazon.com>
Date: Fri, 27 Dec 2024 07:09:35 +0000
Subject: [PATCH] Add test for loading rdb onto non-bloom cluster

---
 tests/test_save_and_restore.py | 45 ++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/tests/test_save_and_restore.py b/tests/test_save_and_restore.py
index cdc25b2..ac84529 100644
--- a/tests/test_save_and_restore.py
+++ b/tests/test_save_and_restore.py
@@ -1,6 +1,8 @@
 import pytest, time
 import os
+from valkey import ResponseError
 from valkey_bloom_test_case import ValkeyBloomTestCaseBase
+from valkey_test_case import ValkeyServerHandle
 from valkeytests.conftest import resource_port_tracker
 from util.waiters import *
 
@@ -96,3 +98,46 @@ def test_restore_failed_large_bloom_filter(self):
         self.wait_for_logfile(logfile, large_obj_restore_err)
         self.wait_for_logfile(logfile, internal_rdb_err)
         assert not self.server.is_alive()
+
+    def test_rdb_restore_version_compatibility(self):
+        # Create a rdb on bloom-module enabled server
+        bf_server = ValkeyServerHandle(bind_ip=self.get_bind_ip(), port=self.get_bind_port(), port_tracker=self.port_tracker,
+                                        cwd=self.testdir, server_id=self.server_id, server_path=self.server_path)
+        bf_server.set_startup_args({
+            'loadmodule': os.getenv('MODULE_PATH'),
+            'bf.bloom-use-random-seed': self.use_random_seed,
+        })
+        bf_server.start()
+        assert bf_server.is_alive()
+        bf_client = bf_server.get_new_client()
+        bf_client.execute_command("BF.ADD key val")
+        bf_client.execute_command("set string val")
+        assert bf_client.info_obj().num_keys() == 2
+        assert bf_client.execute_command("del key") == 1
+        assert bf_client.info_obj().num_keys() == 1
+        assert bf_client.get("string") == b"val"
+        bf_client.bgsave()
+        bf_server.wait_for_save_done()
+        rdb_file = bf_server.args["dbfilename"]
+
+        # Create a server without bloom-module
+        self.server_id += 1
+        new_server = ValkeyServerHandle(bind_ip=self.get_bind_ip(), port=self.get_bind_port(), port_tracker=self.port_tracker,
+                                        cwd=self.testdir, server_id=self.server_id, server_path=self.server_path)
+        new_server.set_startup_args({"dbfilename": rdb_file})
+        new_server.start()
+        assert new_server.is_alive()
+        new_client = new_server.get_new_client()
+        wait_for_equal(lambda: new_server.is_rdb_done_loading(), True)
+
+        # Verification
+        assert new_client.execute_command("info bf") == b''
+        try:
+            new_client.execute_command("bf add test val")
+            assert False
+        except ResponseError as e:
+            assert "unknown command" in str(e)
+
+        assert new_client.info_obj().num_keys() == 1
+        assert new_client.info_obj().num_keys() == 1
+        assert new_client.get("string") == b"val"