Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator.js email validation suspectible to ReDoS #293

Closed
nubok opened this issue Jun 8, 2014 · 2 comments
Closed

validator.js email validation suspectible to ReDoS #293

nubok opened this issue Jun 8, 2014 · 2 comments

Comments

@nubok
Copy link

nubok commented Jun 8, 2014

Just call

validator.isEmail('"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa');

and see what happens to the node.js engine (hint: it'll hang). Thus if Malory is able to make you call validator.isEmail(...) on a parameter he passed, he can do a DoS on a web appication using validator.js.

Background of this dangerous bug: http://en.wikipedia.org/wiki/ReDoS.

@Vadorequest
Copy link

Ouch. Thanks for pointing this out!
Basically I lost my tab and my I7 processor went crazy up to 25% with a single tab. Didn't try server side but I believe in the DoS issue.

@chriso
Copy link
Collaborator

chriso commented Jun 8, 2014

Dupe of #152.

@chriso chriso closed this as completed Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants