isMobilePhone for Belgian phone numbers validates also non mobile phone numbers

[h3llrais3r]

Describe the bug
The isMobilePhone() validator should only validate mobile phone numbers.
Currently it seems that it also validates the local/regional fixed phone numbers.
Reference: https://en.wikipedia.org/wiki/Telephone_numbers_in_Belgium

Examples
Valid ones:

• 0470123456
• +32470123456
• 32470123456

Invalid ones (but valid local/regional fixed phone numbers):

• 021234567
• +3221234567
• 3221234567

Examples are taking from the test cases:
valid mobile phone numbers: https://github.com/validatorjs/validator.js/blob/master/test/validators.js#L7290-L7292
valid fixed phone numbers (but no valid mobile phone numbers): https://github.com/validatorjs/validator.js/blob/master/test/validators.js#L7293-L7295

Additional context
Validator.js version: 13.6.0
Node.js version: 12.x
OS platform: windows

Possible fix (not fully tested):
Replace regex /^(\+?32|0)4?\d{8}$/ by /^(\+?32|0)4\d{8}$/
at https://github.com/validatorjs/validator.js/blob/master/src/lib/isMobilePhone.js#L97

This should only allow:

• 04xxxxxxxx (10 digits, 04 followed by 8 digits)
• 324xxxxxxxx (9 digits, leading 0 omitted, after country code without +)
• +324xxxxxxxx (9 digits, lading 0 omitted, after country code)

You can even go further and also only allow the range of 04xx numbers by provider (see wikipedia), but I think that would go too far and it also has a risk that you need to adapt your regex if a new provider (or range) is added.

[rubiin]

Would you like to create a PR?

[h3llrais3r]

@rubiin Yes, can make a PR if you want.
But just to be sure: should isMobilePhone() only validate mobile phone numbers, or also fixed phone numbers?
Because in Belgium, both are used, and both have a different format.

[fedeci]

It should only validate mobile phone numbers.

[profnandaa]

Thanks for noting, sure, make a PR.

[divikshrivastava]

@profnandaa @ezkemboi Can I raise a PR for this issue, I have verified the given regex with some random Belgian numbers I could find online.

[tux-tn]

@divikshrivastava sure, go ahead!

[divikshrivastava]

Thanks for go ahead! Added the PR @tux-tn
#1746

[YASH3166]

Can I raise a PR for this issue?

[ezkemboi]

@YASH3166 seems Pr has been raised

[tux-tn]

Closing since PR raised #1746 and merged. Sorry @YASH3166 , feel free to pick another issue!