Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation not working with 'require_tld' = true #1652

Open
stevehobbsdev opened this issue Apr 20, 2021 · 5 comments
Open

Email validation not working with 'require_tld' = true #1652

stevehobbsdev opened this issue Apr 20, 2021 · 5 comments

Comments

@stevehobbsdev
Copy link

Describe the bug
I am using isEmail to validate email addresses with require_tld set as the default of true, and noticed an anomaly:

example@example correctly fails validation.

example.example@example passes validation.

Given that require_tld is true I would have expected the second example to fail, or am I mistaken?

Additional context
Validator.js version: 13.6.0
Node.js version: 12.9.1
OS platform: [windows, linux, macOS, etc] macOS

@profnandaa
Copy link
Member

profnandaa commented Apr 20, 2021

/cc. @tux-tn -- check if it has to do with #1651

@tux-tn
Copy link
Member

tux-tn commented Apr 20, 2021

Very strange behaviour, i can't even reproduce it with validator@13.6.0 (as you can see in this runKit )
@stevehobbsdev Can you share with us a code snippet with the issue?

@stevehobbsdev
Copy link
Author

@tux-tn Odd - let me see if I can reproduce it will a small repro and get back to you, probably early next week.

@tux-tn
Copy link
Member

tux-tn commented May 1, 2021

@stevehobbsdev any news?

@stevehobbsdev
Copy link
Author

@tux-tn I haven't had a chance to properly evaluate on our end yet, but it clearly works as intended from your runKit.

So at the moment it looks like it's an issue our end. Perhaps we could close this and I could come back to you if I find something more? Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants