Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Make AllPubKeys and BasicAuths methods on OCIValidatorSpec; import from validatorctl #279

Closed
TylerGillson opened this issue Aug 23, 2024 · 0 comments · Fixed by #289
Closed

🌱 Make AllPubKeys and BasicAuths methods on OCIValidatorSpec; import from validatorctl #279

TylerGillson opened this issue Aug 23, 2024 · 0 comments · Fixed by #289
Assignees
@ahmad-ibra
Labels
enhancement Enhancement to an existing feature

Comments

@TylerGillson
Copy link
Member

TylerGillson commented Aug 23, 2024 •
edited
Loading

Summary

Add Direct to method names for clarity.

  • For AllPubKeysDirect, ensure the key is rule.Name(), not a secret name
  • For BasicAuthsDirect, we only care about the creds in the spec, not secrets
  • Remove AllPubKeys and BasicAuths from validatorctl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmad-ibra ahmad-ibra

Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@TylerGillson @ahmad-ibra