chore: only add auth and pubkeys when they're not empty #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage ? 63.22%
=======================================
Files ? 8
Lines ? 503
Branches ? 0
=======================================
Hits ? 318
Misses ? 151
Partials ? 34
Continue to review full report in Codecov by Sentry.
|
dosubot
bot
added
size:XS
TylerGillson
approved these changes
Aug 12, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2024-08-16) ### Bug Fixes * support private ecr registry validation with a per rule aws env vars ([#268](#268)) ([42a5610](42a5610)) ### Other * only add auth and pubkeys when they're not empty ([#260](#260)) ([5b21888](5b21888)) ### Dependency Updates * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to d4ae6cf ([#265](#265)) ([1c4f7f2](1c4f7f2)) * **deps:** update module github.com/validator-labs/validator to v0.1.3 ([#258](#258)) ([4161664](4161664)) * **deps:** update module github.com/validator-labs/validator to v0.1.5 ([#263](#263)) ([a5fc455](a5fc455)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.0 ([#261](#261)) ([9847a0a](9847a0a)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.18.5 ([#262](#262)) ([e2f73a2](e2f73a2)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0 ([#267](#267)) ([eaa40aa](eaa40aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
We were always populating the auth and allPubKeys maps which meant that we were unneccesarily calling the oci clients
WithVerificationPublicKeysandWithBasicAuthfunctions for every rule (even those with no auth or pubkeys).Nothing was actually broken, but this is a more correct implementation