Fix - Fatal error when facebook_config option is empty. #2517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
We received a report of a fatal error in the Pixel Event class. After investigation, I noticed that if the
facebook_config
option is an empty string, the value returned by get_options would be an empty string, causing the exception:error message: Uncaught TypeError: Cannot access offset of type string on string
.This assumes that
facebook_config
will always contain a serialized object, and the error is, in fact, caused by thefacebook_config
option being empty.Closes #2516.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Detailed test instructions:
Changelog entry