Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type:module support #65

Closed
fregante opened this issue Aug 10, 2020 · 0 comments · Fixed by #67
Closed

Fix type:module support #65

fregante opened this issue Aug 10, 2020 · 0 comments · Fixed by #67
Labels
bug help wanted

Comments

@fregante
Copy link
Collaborator

The package.json was set to type:module but it's not really a valid one (sigh, sindresorhus/project-ideas#116) because a dependency is a JSON file — they're not yet considered valid ES modules.

Fixing it requires bundling the JS file or vendoring it (easier)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Node {"type": "module"} support vadimdemedes/dom-chef
1 participant
@fregante