Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

13/WAKU-STORE: Use multiformat for waku-store digest #301

Closed
D4nte opened this issue Mar 16, 2021 · 4 comments · Fixed by #353
Closed

13/WAKU-STORE: Use multiformat for waku-store digest #301

D4nte opened this issue Mar 16, 2021 · 4 comments · Fixed by #353
Assignees

Comments

@D4nte
Copy link
Contributor

D4nte commented Mar 16, 2021

As discussed, in the waku store specs, little information is provided about the digest.
If we do not want to restrict the digest to a specific hash function, then I would suggest to use multihash format.

@oskarth oskarth changed the title Use multiformat for waku-store digest 13/WAKU-STORE: Use multiformat for waku-store digest Mar 31, 2021
@staheri14
Copy link
Contributor

Thanks @D4nte for opening the issue and the suggestion!
Thinking that maybe it would be better to enforce a particular hashing function in order to provide consistency across different store nodes. This way, paging indices (cursors) would be reusable from one store node to another.
@oskarth please let me know your thoughts on this.

@staheri14
Copy link
Contributor

In any case, this must be reflected on the specs level to avoid confusion.

@oskarth
Copy link
Contributor

oskarth commented Apr 6, 2021

Agree re having a default hashing function explicit. I suppose something like multihash could be used but still generally locked down to a specific hash function? Do we see any specific need for flexibility here? What does Eth2 do?

@staheri14
Copy link
Contributor

staheri14 commented Apr 20, 2021

Eth2

@oskarth
Looking at eth2 specs, the type of hash function is explicitly stated, Also could not see any use of multihash format
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/beacon-chain.md#crypto
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/beacon-chain.md#custom-types

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants