fix: ensure validation is triggered before change event #6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
changed the title
1 task
web-padawan
approved these changes
Jul 19, 2023
sissbruecker
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR ensures combo-box's validation is triggered before the
changeevent, aligning it with the behavior of other field components. Additionally, this fixes another bug where validation wasn't run at all when pressing Enter or clicking the clear button, despite a change event being fired immediately in that case.A follow-up to #6164
Part of vaadin/flow-components#5712
Type of change