fix: ensure user input is reverted before validation on blur #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
1 task
vursen
commented
Jul 14, 2023
| * @protected | ||
| * @override | ||
| */ | ||
| _setFocused(focused) { |
There was a problem hiding this comment.
note: By moving the overlay closing logic to _setFocused, we ensure the correct sequence: the overlay closes first, and then the validation occurs.
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
commented
Jul 14, 2023
| @@ -87,6 +88,14 @@ describe('validation', () => { | |||
| expect(comboBox.validate()).to.be.true; | |||
| expect(comboBox.invalid).to.be.false; | |||
| }); | |||
|
|
|||
| it('should be invalid after user input is reverted on blur', async () => { | |||
There was a problem hiding this comment.
note: The test that covers the issue.
vursen
commented
Jul 14, 2023
| @@ -1029,7 +1029,7 @@ describe('lazy loading', () => { | |||
| let returnedItems; | |||
|
|
|||
| const bluringDataProvider = (params, callback) => { | |||
| comboBox.blur(); | |||
| comboBox.inputElement.blur(); | |||
There was a problem hiding this comment.
note: The combo-box-light doesn't delegate blur() calls to the input element.
web-padawan
approved these changes
Jul 14, 2023
vursen
deleted the
should-be-invalid-after-user-input-is-reverted-on-blur
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
<combo-box required>didn't get invalidated after entering an invalid value and subsequently clicking outside. The issue occurred becausecombo-boxtriggered validation before reverting user input and from the perspective of the HTML constraint validation, it appeared as ifcombo-boxhad a value.Along the way, the PR fixes
combo-box-lightnot getting validated on blur and also adds thefocusedattribute for it.Fixes #6164, vaadin/flow-components#5712
Type of change