Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not validate when focus is moving inside the field #4478

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Sep 5, 2022

Description

This PR prevents date-time-picker from being validated when focus is moving inside it, for example, between child pickers. The field should be only validated when focus moves away.

Fixes #4461

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen marked this pull request as ready for review September 5, 2022 09:34
@web-padawan web-padawan merged commit baf313b into master Sep 5, 2022
@web-padawan web-padawan deleted the fix/date-time-picker/do-not-validate-when-moving-focus-between-pickers branch September 5, 2022 10:13
@vaadin-bot
Copy link
Collaborator

Hi @vursen , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick baf313b
error: could not apply baf313b... fix: do not validate when moving focus inside the field (#4478)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date-time-picker] Should not trigger validation when focus is moving inside the field
3 participants