Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure initial validation with constraints and value #4410

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 29, 2022

Description

This PR adds unit tests that ensure initial validation for text-area when it has constraints and value.

Extracted from #4386

Part of #4371

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title test: ensure initial validation with constraints and value test(text-area): ensure initial validation with constraints and value Aug 29, 2022
@vursen vursen changed the title test(text-area): ensure initial validation with constraints and value test: ensure initial validation with constraints and value Aug 29, 2022
@vursen vursen force-pushed the refactor/text-area/ensure-initial-validation-with-constraints-and-value branch from b301538 to 2c5b9c1 Compare August 29, 2022 13:41
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit d5cf964 into master Aug 29, 2022
@vursen vursen deleted the refactor/text-area/ensure-initial-validation-with-constraints-and-value branch August 29, 2022 14:43
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.rc1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants