Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: extract validation tests #4376

Merged
merged 2 commits into from
Aug 22, 2022
Merged

test: extract validation tests #4376

merged 2 commits into from
Aug 22, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 22, 2022 •
edited
Loading

Description

  • Extracted text-field validation tests into a separate file
  • Categorized the extracted tests into test suites by constraints.

Part of #4371

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen force-pushed the test/text-field/extract-validation-tests branch from ab67b26 to 43e44f7 Compare August 22, 2022 10:53
@vursen vursen marked this pull request as ready for review August 22, 2022 10:54
@vursen vursen requested a review from tomivirkki August 22, 2022 10:54
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit 3333f16 into master Aug 22, 2022
@vursen vursen deleted the test/text-field/extract-validation-tests branch August 22, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @tomivirkki