New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the missing default value for `value` #4361

Closed

vursen wants to merge 1 commit into master from refactor/add-missing-default-value

Contributor

vursen commented Aug 17, 2022 •

edited

Loading

Description

Polymer works in a way that overriding a property doesn't preserve its default value, so the default value has to be replicated for every override.

This PR adds the missing default value for the value property of multi-select-combo-box which should fix the visual test failures in #4359.

Type of change

Bugfix

Checklist

I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.


          refactor: add missing default value for value property

82848fc

vursen changed the title ~~refactor: add the missing default value for value~~ fix: add the missing default value for value

vursen closed this

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet