Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: validate on constraint change when value is present #4359

Merged
merged 5 commits into from
Aug 18, 2022
Merged

refactor!: validate on constraint change when value is present #4359

merged 5 commits into from
Aug 18, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 16, 2022 •
edited
Loading

Description

This PR modifies InputConstraintsMixin to run validation on constraint change not only when the component is invalid but also when value is present.

Warning
Behavior altering change

Depends on

Part of #4371

Type of change

  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title refactor!: validate on constraint change only if value is present refactor!: validate on constraint change when value is present Aug 16, 2022
@vursen vursen force-pushed the refactor/only-validate-if-value-is-present branch 2 times, most recently from aee98f2 to 709dd30 Compare August 16, 2022 16:20
This was referenced Aug 17, 2022
Closed
Merged
Merged
@vursen vursen force-pushed the refactor/only-validate-if-value-is-present branch from e86d7b0 to 81b6c4f Compare August 17, 2022 19:15
@vursen vursen force-pushed the refactor/only-validate-if-value-is-present branch from 81b6c4f to 479e37f Compare August 18, 2022 08:34
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen marked this pull request as ready for review August 18, 2022 08:53
@web-padawan web-padawan merged commit 3a76063 into master Aug 18, 2022
@web-padawan web-padawan deleted the refactor/only-validate-if-value-is-present branch August 18, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @web-padawan