Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text-area using slotted textarea #2276

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jul 27, 2021

Description

This PR adds @vaadin/text-area base class, Lumo and Material theme, and visual tests.

Fixes #2194

Type of change

  • Feature

@web-padawan web-padawan added the a11y Accessibility issue label Jul 27, 2021
@web-padawan web-padawan force-pushed the feat/text-area branch 2 times, most recently from dc50eb8 to d6ef435 Compare July 28, 2021 07:39
@web-padawan web-padawan marked this pull request as ready for review August 5, 2021 18:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit a865d00 into master Aug 6, 2021
@web-padawan web-padawan deleted the feat/text-area branch August 6, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text-area base class using new mixins
2 participants