-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover is not closing under special configurations #8306
Comments
Currently, |
Is there the possibility to enable this as a configuration (when having no opening trigger defined)? |
Could be considered as an enhancement request. @web-padawan, are there any technical limitations for that? |
Currently, the |
@web-padawan In which version will it be included? |
The PR where this was fixed is technically a behavior altering change so I though that we could postpone it to 24.7 but in case if this is really problematic, maybe we could consider backporting to 24.6 as well. I'll discuss this with the team. |
Any updates on this? - It would be great to have this in the 24.6 |
IMO the behavioral change is small enough, and better in line with developer expectations, that it could be safely backported. |
Description
When having a Popover defined like the following code, the Popover never closes when clicking the backdrop or via ESC - but it is defined to work with this.
Expected outcome
When having CloseOnEsc or OutideClick - the Popover should close in every condition when triggering the defined operations.
Minimal reproducible example
base-gradle-vaadin.zip
Steps to reproduce
Environment
Vaadin version(s): 24.5.7
OS: Windows 11
Variant: Gradle
Browsers
Issue is not browser related
The text was updated successfully, but these errors were encountered: