[date-picker] The value property is not cleared when committing invalid input and autoOpenDisabled

[vursen]

Description

A finding from vaadin/flow-components#1158 (comment)

Trying to commit an invalid input when autoOpenDisabled = true results in the value property holding the previous value, unlike autoOpenDisabled = false where the value property is cleared in that case.

Screen.Recording.2022-11-22.at.17.13.22.mov

Related to vaadin/platform#3066

Expected outcome

The value property should be cleared when trying to commit an invalid input, the same way it currently works when autoOpenDisabled = false

Minimal reproducible example

<vaadin-date-picker auto-open-disabled></vaadin-date-picker>

<script type="module">
  import '@vaadin/date-picker';

  const datePicker = document.querySelector('vaadin-date-picker');
  datePicker.addEventListener('value-changed', (e) => {
    console.log('Value: ', e.detail.value);
  });
</script>

Steps to reproduce

1. Add the above example on an HTML page
2. Enter 1/1/2022 and press Enter to commit the value
3. Enter foobar and press Enter

Environment

Vaadin version(s): Latest
OS: Mac OS

Browsers

Issue is not browser related

[sissbruecker]

Note that the same issue also occurs when blurring the field.

Here's a naive attempt at fixing the issue: 057e3ee. Given how many conditions this removes, I wonder if we are missing some tests.