Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date-time-picker] Should not trigger validation when focus is moving inside the field #4461

Closed
vursen opened this issue Sep 2, 2022 · 0 comments · Fixed by #4478
Closed
Labels
a11y Accessibility issue bug Something isn't working UX User experience issue validation

Comments

@vursen
Copy link
Contributor

vursen commented Sep 2, 2022

Description

date-time-picker triggers validation not only when focus moves away from the field but also when it is moving inside the field. As a result, if the field is required, it gets reported as invalid before the user has actually selected both date and time which is confusing from any perspective: UX, accessibility.

See the video for an illustration:

Screen.Recording.2022-09-02.at.14.24.51.mov

Expected outcome

I would expect the validation to be triggered only when focus moves out of the field.

Minimal reproducible example

<script type="module">
  import '@vaadin/date-time-picker';
</script>
<vaadin-date-time-picker
  label="Birth date and time"
  error-message="error-message"
  required
></vaadin-date-time-picker>

Steps to reproduce

  1. Add the above snippet to an HTML page
  2. Click on the date input.
  3. Press Tab.

Environment

Vaadin version(s): 23.2, also affects older versions.
OS: Mac OS

Browsers

Issue is not browser related

@vursen vursen added bug Something isn't working a11y Accessibility issue UX User experience issue validation labels Sep 2, 2022
@vursen vursen changed the title [date-time-picker] Should not trigger validation when focus moves inside the field [date-time-picker] Should not trigger validation when focus is moving inside the field Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue bug Something isn't working UX User experience issue validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant