fix: add missing section type to dashboard events (#8325)

* fix: add missing section type to dashboard events * revert type for resize move changed event
vaadin · Dec 11, 2024 · a9ff39d · a9ff39d
1 parent 2f7bc89
commit a9ff39d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/packages/dashboard/src/vaadin-dashboard.d.ts b/packages/dashboard/src/vaadin-dashboard.d.ts
@@ -68,7 +68,7 @@ export type DashboardRenderer<TItem extends DashboardItem> = (
  * Fired when an item was moved
  */
 export type DashboardItemMovedEvent<TItem extends DashboardItem> = CustomEvent<{
-  item: TItem;
+  item: TItem | DashboardSectionItem<TItem>;
 
   items: Array<TItem | DashboardSectionItem<TItem>>;
 
@@ -97,15 +97,15 @@ export type DashboardItemRemovedEvent<TItem extends DashboardItem> = CustomEvent
  * Fired when an item selected state changed
  */
 export type DashboardItemSelectedChangedEvent<TItem extends DashboardItem> = CustomEvent<{
-  item: TItem;
+  item: TItem | DashboardSectionItem<TItem>;
   value: boolean;
 }>;
 
 /**
  * Fired when an item move mode changed
  */
 export type DashboardItemMoveModeChangedEvent<TItem extends DashboardItem> = CustomEvent<{
-  item: TItem;
+  item: TItem | DashboardSectionItem<TItem>;
   value: boolean;
 }>;
 

diff --git a/packages/dashboard/test/typings/dashboard.types.ts b/packages/dashboard/test/typings/dashboard.types.ts
@@ -75,7 +75,8 @@ assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(s
 
 narrowedDashboard.addEventListener('dashboard-item-moved', (event) => {
   assertType<DashboardItemMovedEvent<TestDashboardItem>>(event);
-  assertType<TestDashboardItem>(event.detail.item);
+  assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
+  assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
   assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(event.detail.items);
   assertType<DashboardSectionItem<TestDashboardItem> | undefined>(event.detail.section);
 });
@@ -88,19 +89,22 @@ narrowedDashboard.addEventListener('dashboard-item-resized', (event) => {
 
 narrowedDashboard.addEventListener('dashboard-item-removed', (event) => {
   assertType<DashboardItemRemovedEvent<TestDashboardItem>>(event);
-  assertType<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>(event.detail.item);
+  assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
+  assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
   assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(event.detail.items);
 });
 
 narrowedDashboard.addEventListener('dashboard-item-selected-changed', (event) => {
   assertType<DashboardItemSelectedChangedEvent<TestDashboardItem>>(event);
-  assertType<TestDashboardItem>(event.detail.item);
+  assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
+  assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
   assertType<boolean>(event.detail.value);
 });
 
 narrowedDashboard.addEventListener('dashboard-item-move-mode-changed', (event) => {
   assertType<DashboardItemMoveModeChangedEvent<TestDashboardItem>>(event);
-  assertType<TestDashboardItem>(event.detail.item);
+  assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
+  assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
   assertType<boolean>(event.detail.value);
 });