Added vaadin-checkbox-group MVP

[sohrabtaee]

Fixes #100

---

This change is 

[CLAassistant]

All committers have signed the CLA.

[tomivirkki]

gulpfile.js, line 6 at r1 (raw file):

var eslint = require('gulp-eslint');
var htmlExtract = require('gulp-html-extract');
var lec = require('gulp-line-ending-corrector');

Please revert. Changes that concern all components should go trough skeleton. The lint process should also only validate without side-effects.

---

Comments from Reviewable

[tomivirkki]

Review status: 0 of 15 files reviewed, 4 unresolved discussions (waiting on @sohrabtaee and @tomivirkki)

---

vaadin-checkbox-group.html, line 1 at r1 (raw file):

<link rel="import" href="theme/lumo/vaadin-checkbox-group.html">

Missing an empty line

---

demo/index.html, line 15 at r1 (raw file):

  <script src="./checkbox-demo.js"></script>
  <link rel="import" href="../../iron-form/iron-form.html">

All these need to be added to bower.json as devDependencies

---

src/vaadin-checkbox-group.html, line 164 at r1 (raw file):

    })();
  </script>
</dom-module>

Needs a new line

---

Comments from Reviewable

[tomivirkki]

src/vaadin-checkbox-group.html, line 97 at r1 (raw file):

            this._filterCheckboxes(info.removedNodes).forEach(checkbox => {
              checkbox.removeEventListener('checked-changed', checkedChangedListener);

The coverage report fails because these two lines aren't tested

---

Comments from Reviewable

[manolo]

Please check why coverage fails and why polymer 3 conversion build fails. We need the PR green

---

Review status: 0 of 15 files reviewed, 5 unresolved discussions (waiting on @sohrabtaee and @tomivirkki)

---

Comments from Reviewable

[yuriy-fix]

Reviewed 15 of 15 files at r1.
Review status: all files reviewed, 8 unresolved discussions (waiting on @sohrabtaee)

---

package.json, line 46 at r1 (raw file):

  },
  "dependencies": {
    "gulp-line-ending-corrector": "^1.0.2"

Can be removed due to the comment above (about lint process in gulpfile.js).

---

src/vaadin-checkbox-group.html, line 93 at r1 (raw file):

                checkbox.disabled = true;
              }
              this._changeSelectedCheckbox(checkbox);

Nit: untested line of code.

---

src/vaadin-checkbox-group.html, line 148 at r1 (raw file):

          // reflect the value array to checkboxes
          this._checkboxes.forEach(checkbox => {
            checkbox.checked = newV.includes(checkbox.value);

Seems to be causing issue with the build. Probably smth like indexOf can be used instead.

---

Comments from Reviewable

[sohrabtaee]

Review status: 10 of 14 files reviewed, 7 unresolved discussions (waiting on @YuriyVaadin and @tomivirkki)

---

vaadin-checkbox-group.html, line 1 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Missing an empty line

Done.

---

demo/index.html, line 15 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

All these need to be added to bower.json as devDependencies

Done.

---

src/vaadin-checkbox-group.html, line 97 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

The coverage report fails because these two lines aren't tested

Done.

---

src/vaadin-checkbox-group.html, line 148 at r1 (raw file):

Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Seems to be causing issue with the build. Probably smth like indexOf can be used instead.

Done.

---

src/vaadin-checkbox-group.html, line 164 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Needs a new line

Done.

---

gulpfile.js, line 6 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Please revert. Changes that concern all components should go trough skeleton. The lint process should also only validate without side-effects.

Done.

---

package.json, line 46 at r1 (raw file):

Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Can be removed due to the comment above (about lint process in gulpfile.js).

Done.

---

Comments from Reviewable

[tomivirkki]

---

Reviewed 10 of 15 files at r1, 6 of 6 files at r2.
Review status: all files reviewed, 2 unresolved discussions (waiting on @YuriyVaadin)

---

Comments from Reviewable

[sohrabtaee]

Reviewed 1 of 1 files at r3.
Review status: all files reviewed, 2 unresolved discussions (waiting on @YuriyVaadin)

---

Comments from Reviewable

[yuriy-fix]

---

Reviewed 4 of 6 files at r2, 1 of 1 files at r3.
Review status: complete! all files reviewed, all discussions resolved

---

Comments from Reviewable