Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 drag'n'drop doesn't work with Images #12604

Closed
Ansku opened this issue Jan 26, 2024 · 0 comments
Closed

HTML5 drag'n'drop doesn't work with Images #12604

Ansku opened this issue Jan 26, 2024 · 0 comments
Assignees

Comments

@Ansku
Copy link
Member

Ansku commented Jan 26, 2024

DropTargetExtensionConnector blocks the drop if the event.dataTransfer contains a type Files. The purpose of that is to keep the listener from consuming the event if an actual file is dragged onto the drop target, so that the same area can optionally be used as a FileDropTarget too. However, the current check accidentally also blocks Image components, as well as some (but not all) other components that contain an <img> tag, like a Label that has an icon set to the caption (but not a Button with the same icon set).

See also https://support.vaadin.com/browse/VS-5045 (internal access only)

@Ansku Ansku self-assigned this Jan 26, 2024
@Ansku Ansku closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant