Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a config property enabling new validation mechanism #17056

Merged
merged 7 commits into from
Jun 21, 2023
Merged

feat: add a config property enabling new validation mechanism #17056

merged 7 commits into from
Jun 21, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jun 19, 2023 •
edited
Loading

Description

Introduces a new config property that enables the new validation mechanism for Flow components.

Fixes vaadin/flow-components#5122

Type of change

  • Feature

@vursen vursen changed the title feat: add a config property enabling full experience field validation (WIP) feat: add a config property enabling new validation mechanism (WIP) Jun 19, 2023
@mshabarov mshabarov self-requested a review June 19, 2023 11:26
@vursen vursen mentioned this pull request Jun 19, 2023
Merged
@vursen vursen changed the title feat: add a config property enabling new validation mechanism (WIP) feat: add a config property enabling new validation mechanism Jun 21, 2023
@vursen vursen marked this pull request as ready for review June 21, 2023 10:11
@mshabarov mshabarov changed the base branch from 2.9 to 2.10 June 21, 2023 10:22
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov mshabarov merged commit a107b74 into 2.10 Jun 21, 2023
@mshabarov mshabarov deleted the feat/new-validation-mechanism-feature-flag branch June 21, 2023 10:30
@vursen vursen mentioned this pull request Jun 21, 2023
Merged
1 task
mshabarov pushed a commit that referenced this pull request Jun 21, 2023
@vursen
docs: clarify that new validation mechanism is disabled by default (#…
51deccb 
…17072)

The PR clarifies in JavaDoc that the new validation mechanism is disabled by default in Vaadin 14.

A follow-up to #17056
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.11.0.alpha1 and is also targeting the upcoming stable 14.11.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 14.11.0 Released with Vaadin 14.11.0.alpha1 +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @vaadin-bot @mshabarov