Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the enforceFieldValidation feature flag #16248

Merged
merged 1 commit into from
Mar 13, 2023
Merged

chore: remove the enforceFieldValidation feature flag #16248

merged 1 commit into from
Mar 13, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Mar 13, 2023 •
edited
Loading

Description

Removed the enforcedFieldValidation feature flag because the new validation mechanism has been enabled by default since v24.

Part of vaadin/platform#3066

@vursen vursen requested review from Artur- and mshabarov and removed request for Artur- March 13, 2023 13:53
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   951 files  ±  0     951 suites  ±0   57m 29s ⏱️ + 2m 26s
6 036 tests ±  0  6 001 ✔️ ±  0  35 💤 ±0  0 ❌ ±0 
6 278 runs   - 16  6 236 ✔️  - 16  42 💤 ±0  0 ❌ ±0 

Results for commit c5f3feb. ± Comparison against base commit c55e06d.

@czp13 czp13 self-requested a review March 13, 2023 15:41
@Artur- Artur- merged commit 35c7746 into main Mar 13, 2023
@Artur- Artur- deleted the chore/remove-feature-flag branch March 13, 2023 17:29
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @Artur-, when i performed cherry-pick to this commit to 24.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 35c7746
error: could not apply 35c7746... chore: remove the enforceFieldValidation feature flag (#16248)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vursen added a commit that referenced this pull request Mar 15, 2023
@vursen
chore: remove the enforceFieldValidation feature flag (#16248)
970f55e
@vursen vursen mentioned this pull request Mar 15, 2023
Merged
mshabarov pushed a commit that referenced this pull request Mar 15, 2023
@vursen
chore: remove the enforceFieldValidation feature flag (#16248) (CP: 2…
6ee0214 
…4.0) (#16262)

* chore: remove the enforceFieldValidation feature flag (#16248)

* fix errors after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artur- Artur- Artur- approved these changes

@czp13 czp13 czp13 approved these changes

@mshabarov mshabarov Awaiting requested review from mshabarov

Assignees
No one assigned
Labels
need to pick manually 24.0 +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vursen @vaadin-bot @Artur- @czp13