feat: enable components to notify binder when validation state changes (#13940) (CP: 23.1) #13993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
knoobie
reviewed
Jun 16, 2022
| * | ||
| * @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider, | ||
| * Setter) | ||
| * @since 23.2 |
There was a problem hiding this comment.
if this method is down-ported to anything from 14.x to 23.1.x - this since tag is really weird
There was a problem hiding this comment.
Yes, good catch. @since 2.7 would be better.
mshabarov
reviewed
Jun 17, 2022
flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java
Outdated
Show resolved
Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeEvent.java
Outdated
Show resolved
Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeListener.java
Outdated
Show resolved
Hide resolved
mshabarov
approved these changes
Jun 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 23.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.