Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vaadin/router 1.7.2 is failing some routing related integration tests in Flow #8236

Closed
2 tasks
haijian-vaadin opened this issue May 5, 2020 · 0 comments · Fixed by #9536
Closed
2 tasks
Labels
hilla Issues related to Hilla

Comments

@haijian-vaadin
Copy link
Contributor

haijian-vaadin commented May 5, 2020

@vaadin/router 1.7.2 fixed some routing issues in Flow (#7665, #7572, #8071), it's causing some regressions in Flow, the following Integration tests are failing

  • MultipleAnchorsIT#numerousEqualAnchorsShouldRepresentOneHistoryEntry. In router 1.7.2, click on the same link will call the lifecycle callbacks. But for the anchors which only update hash in the URL, it's better not to call the callbacks, as asserted in this test.
  • ScrollIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant