Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion : PopStateHandlerIT fails #10485

Closed
denis-anisimov opened this issue Mar 30, 2021 · 2 comments · Fixed by #10750
Closed

Fusion : PopStateHandlerIT fails #10485

denis-anisimov opened this issue Mar 30, 2021 · 2 comments · Fixed by #10750
Assignees
Labels
hilla Issues related to Hilla

Comments

@denis-anisimov
Copy link
Contributor

PopStateHandlerIT had a number of hasClientIssue("7572") which effectively disabled some piece of test in every test method.

I'm going to make a PR and change the test to disable the parts which are failing .

But the all the tests should work in the end. The fix for this ticket should remove all disabled parts (and may be just return the test state to the same as it has e.g. in 2.5 branch).

Similar ticket: #7572.

For some reason #7572 doesn't mention PopStateHandlerIT anyhow.

@denis-anisimov denis-anisimov added the hilla Issues related to Hilla label Mar 30, 2021
@denis-anisimov
Copy link
Contributor Author

This PR disables failing parts : #10486

@haijian-vaadin
Copy link
Contributor

TODOs:

  1. Find out why the IT is failing with new bootstrapping, update the test to make it green. Open a discussion if the test is irrelevant.
  2. Test against the v14 bootstrapping mode is out of scope for this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants