-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass id provider to keymapper also #6632
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however, I'd recommend to add an end-to-end test that asserts the MSCB marks all duplicates checked, when identity provider is defined.
That's the point of this fix - selection for duplicates. Before it, MSCB didn't tick duplicates.
I can't test it with an IT via Testbench API since ComboBox does not differentiate on the amount of selected items if they are considered equal. Also a screenshot comparison test does not seem to work. So hopefully the unit test for checking that the id providers match is enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's stick with only the unit test then.
Let's Design System team decide if it can be merge and make another review, if needed.
Quality Gate passedIssues Measures |
Fixes vaadin/flow#19361