Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass id provider to keymapper also #6632

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Sep 10, 2024

@tepi tepi marked this pull request as draft September 10, 2024 11:59
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, I'd recommend to add an end-to-end test that asserts the MSCB marks all duplicates checked, when identity provider is defined.

That's the point of this fix - selection for duplicates. Before it, MSCB didn't tick duplicates.

@tepi
Copy link
Contributor Author

tepi commented Sep 26, 2024

Looks good to me, however, I'd recommend to add an end-to-end test that asserts the MSCB marks all duplicates checked, when identity provider is defined.

That's the point of this fix - selection for duplicates. Before it, MSCB didn't tick duplicates.

I can't test it with an IT via Testbench API since ComboBox does not differentiate on the amount of selected items if they are considered equal. Also a screenshot comparison test does not seem to work. So hopefully the unit test for checking that the id providers match is enough.

Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's stick with only the unit test then.

Let's Design System team decide if it can be merge and make another review, if needed.

Copy link

sonarcloud bot commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants