Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: restructure and enhance validation unit tests #4350

Merged
merged 9 commits into from
Dec 14, 2022
Merged

test: restructure and enhance validation unit tests #4350

merged 9 commits into from
Dec 14, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 13, 2022 •
edited
Loading

Description

  • Moved binder unit tests to the validation namespace.
  • Introduced unit tests that ensure the component properly implements the HasValidation interface methods. That was previously covered by integration tests.

Note
I'm planning to cover the rest components in a separate PR.

Part of vaadin/platform#3066

Covered components

  • TextField
  • TextArea
  • EmailField
  • IntegerField
  • NumberField
  • PasswordField
  • BigDecimalField

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title test: restructure and improve validation unit tests test: restructure and enhance validation unit tests Dec 13, 2022
vursen and others added 4 commits December 14, 2022 09:39
@vursen @sissbruecker
Update vaadin-text-field-flow-parent/vaadin-text-field-flow/src/test/…
3ef6322 
…java/com/vaadin/flow/component/textfield/validation/AbstractBasicValidationTest.java

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vursen @sissbruecker
Update vaadin-text-field-flow-parent/vaadin-text-field-flow/src/test/…
7d0ff4b 
…java/com/vaadin/flow/component/textfield/validation/AbstractBasicValidationTest.java

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vursen @sissbruecker
Update vaadin-text-field-flow-parent/vaadin-text-field-flow/src/test/…
9ef0423 
…java/com/vaadin/flow/component/textfield/validation/AbstractBasicValidationTest.java

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vursen @sissbruecker
Update vaadin-text-field-flow-parent/vaadin-text-field-flow/src/test/…
9b52ea9 
…java/com/vaadin/flow/component/textfield/validation/AbstractBasicValidationTest.java

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vursen vursen marked this pull request as ready for review December 14, 2022 07:39
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker merged commit c913d04 into master Dec 14, 2022
@sissbruecker sissbruecker deleted the text-field/replace-validation-its-with-unit-tests branch December 14, 2022 09:03
@vursen vursen mentioned this pull request Dec 14, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @sissbruecker