Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextArea] Implement the new validation behavior #4213

Closed
vursen opened this issue Nov 25, 2022 · 0 comments · Fixed by #4258
Closed

[TextArea] Implement the new validation behavior #4213

vursen opened this issue Nov 25, 2022 · 0 comments · Fixed by #4258
Assignees

Comments

@vursen
Copy link
Contributor

vursen commented Nov 25, 2022

An overview of the changes to be done

  • Prevent the web component from setting itself to valid using ClientValidationUtil.
  • Trigger constraint validation on client validated event
 (requires the HasClientValidation interface).
  • Trigger binder validation on client validated event (requires the HasValidator interface).

See TextField for an example.

Constraints to be tested

  • required
  • minlength
  • maxlength
  • pattern

Additional context

All changes should be implemented behind the feature flag enforceFieldValidation on top of the existing implementation.

There are abstract classes AbstractValidationIT and AbstractValidationPage which are supposed to be extended when testing validation for a specific component.

Part of vaadin/platform#3066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants