MenuItem DisableOnClick

[zanonmark]

Description of the bug

It could be useful to have .setDisableOnClick(boolean) on MenuItems too, as the code associated with them could be heavy to run.

[pleku]

Thanks for the feature request, I've transferred it to the context menu Java integration repository.

[jcgueriaud1]

As a workaround to disable the menu item on click, you can do this:

MenuBar menuBar = new MenuBar();
Text selected = new Text("");
ComponentEventListener<ClickEvent<MenuItem>> listener = e -> {
    UI ui = getUI().get();
    selected
            .setText("Starting a task");
    new Thread(() -> {
        try {
            // simulate a long action
            Thread.sleep(2_000);
        } catch (InterruptedException ex) {
            throw new RuntimeException(ex);
        }
        ui.access(() -> {
            selected.setText("Finished a task");
            getElement().executeJs(
                    "$0.disabled = false;", e.getSource());
            ui.push();
        });

    }).start();
};
Div message = new Div(new Text("Clicked item: "), selected);

MenuItem menuItem = menuBar.addItem("View", listener);

getElement().executeJs(
        "$0.addEventListener('click', b => { $0.disabled = true;});", menuItem);

menuBar.addItem("Edit", listener);

getContent().add(menuBar,
        message);

[sissbruecker]

Some notes from investigating this:

• The logic can be adapted from Button
• As with Button, the component should register a JS click handler to disable the element immediately on the client in case the roundtrip takes longer. While the menu usually closes on its own when selecting an item, there is an option to keep it open, in which case getting immediate feedback on the item being disabled is useful.
• Disabling the menu item through JS resulted in the menu not closing anymore after clicking the item. Adding a timeout for disabling the item worked.
• There might be an opportunity to extract the disable on click behavior into a controller that can be applied to Button, MenuItem and maybe other components in the future.