From d9702caa6282b2bfe441341d28b17f4f1cafb629 Mon Sep 17 00:00:00 2001 From: Tomi Virkki Date: Tue, 13 Sep 2022 13:15:05 +0300 Subject: [PATCH] test: update dtp tests to be in line with web component changes See https://github.com/vaadin/web-components/pull/4478 --- .../validation/DateTimePickerValidationBasicIT.java | 10 +--------- .../validation/DateTimePickerValidationBinderIT.java | 4 +++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBasicIT.java b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBasicIT.java index 96aeb2699af..6e57f215df1 100644 --- a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBasicIT.java +++ b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBasicIT.java @@ -65,18 +65,10 @@ public void detach_attach_onlyServerCanSetFieldToValid() { } @Test - public void required_triggerDateInputBlur_assertValidity() { + public void required_triggerBlur_assertValidity() { $("button").id(REQUIRED_BUTTON).click(); dateInput.sendKeys(Keys.TAB); - assertServerInvalid(); - assertClientInvalid(); - } - - @Test - public void required_triggerTimeInputBlur_assertValidity() { - $("button").id(REQUIRED_BUTTON).click(); - timeInput.sendKeys(Keys.TAB); assertServerInvalid(); assertClientInvalid(); diff --git a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBinderIT.java b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBinderIT.java index 487014627d0..aed33dc29b1 100644 --- a/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBinderIT.java +++ b/vaadin-date-time-picker-flow-parent/vaadin-date-time-picker-flow-integration-tests/src/test/java/com/vaadin/flow/component/datetimepicker/validation/DateTimePickerValidationBinderIT.java @@ -38,6 +38,7 @@ public void fieldIsInitiallyValid() { @Test public void required_triggerDateInputBlur_assertValidity() { dateInput.sendKeys(Keys.TAB); + timeInput.sendKeys(Keys.TAB); assertServerInvalid(); assertClientInvalid(); assertErrorMessage(REQUIRED_ERROR_MESSAGE); @@ -76,6 +77,7 @@ public void required_changeInputValue_assertValidity() { public void required_badInput_setDateInputValue_blur_assertValidity() { setInputValue(dateInput, "INVALID"); dateInput.sendKeys(Keys.TAB); + timeInput.sendKeys(Keys.TAB); assertServerInvalid(); assertClientInvalid(); assertErrorMessage(""); @@ -84,7 +86,7 @@ public void required_badInput_setDateInputValue_blur_assertValidity() { @Test public void required_badInput_setTimeInputValue_blur_assertValidity() { setInputValue(timeInput, "INVALID"); - dateInput.sendKeys(Keys.TAB); + timeInput.sendKeys(Keys.TAB); assertServerInvalid(); assertClientInvalid(); assertErrorMessage("");