Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No possibility to choose Lit template in the new Design wizard #2382

Closed
OlliTietavainenVaadin opened this issue Feb 10, 2021 · 5 comments
Closed
Labels
enhancement Impact: High 15% or more of users are affected by the issue.

Comments

@OlliTietavainenVaadin
Copy link
Member

OlliTietavainenVaadin commented Feb 10, 2021

IntelliJ Idea
Designer version: 4.6.2
OS: Windows 10
Vaadin version 14.5.0.alpha3

Designer seems to support Lit templates without issues if you create one manually, but the "new Vaadin 10 Design" dialog/wizard only creates Polymer templates. This means you'll need to create and populate the .ts file with a legit Lit element and the Java connector with suitable annotations in order to start using Designer.

@Peppe
Copy link

Peppe commented Feb 11, 2021

This should have have been covered by #2332.

You should be able to choose if you create TS/Lit or (JS/P3 or HTML/P2) in Designer.

It is closed, so if this doesn't work, it should be fixed.

@tanbt
Copy link
Contributor

tanbt commented Feb 11, 2021

The "new Vaadin 10+ Designer" dialog current only supports template type selection (Lit and Polymer) for Vaadin 15+ projects.

Vaddin 14.5 alpha (or Flow 2.5 alpha) is backporting Lit support, but Designer doesn't support Vaadin 14 + Lit yet.

@OlliTietavainenVaadin
Copy link
Member Author

Good point. I've amended the Vaadin version to the original description.

@tanbt
Copy link
Contributor

tanbt commented Feb 17, 2021

When Lit support for Vaadin 14.5 is ready, Designer should support Lit template selection in the "new Design" wizard, just like it it's done for Vaadin 15+. Otherwise, it's very inconvenient for users to create a Lit template and its companion file manually.

@szolo
Copy link
Contributor

szolo commented Jul 31, 2021

Lit templates support has been implemented for a "New design" wizard. Closed.

@szolo szolo closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Impact: High 15% or more of users are affected by the issue.
Projects
None yet
Development

No branches or pull requests

4 participants