Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub node_modules are incorrectly detected as main node_modules #2056

Closed
anssit opened this issue May 24, 2019 · 0 comments
Closed

Sub node_modules are incorrectly detected as main node_modules #2056

anssit opened this issue May 24, 2019 · 0 comments
Assignees
@szolo @anssit
Labels
bug
Milestone
4.3.0.beta3

Comments

@anssit
Copy link
Contributor

anssit commented May 24, 2019 •
edited
Loading

Steps to reproduce

Have a .project that has one or more nested node_modules folders.

Dnd something from palette to paper.

Actual behavior

Imports are wrong. E.g.

import '@vaadin/flow-deps/node_modules/@vaadin/vaadin-button/src/vaadin-button.js';

Expected behavior

Imports are correct (using ./node_modules at the project root).

IDE, Designer and OS version

Designer 4.0.0.beta1, IntelliJ IDEA, Eclipse, any OS
@anssit anssit added the bug label May 24, 2019
@anssit anssit self-assigned this Jun 5, 2019
@szolo szolo self-assigned this Jun 5, 2019
@szolo szolo closed this as completed Jun 5, 2019
@szolo szolo reopened this Jun 5, 2019
@szolo szolo added this to the 4.3.0.beta3 milestone Jul 4, 2019
@szolo szolo closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szolo szolo

@anssit anssit

Labels
bug
Projects
None yet
Milestone
4.3.0.beta3
Development

No branches or pull requests
2 participants
@szolo @anssit