Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java companion file handling broken in new Eclipse #1987

Closed
ripla opened this issue Jan 4, 2019 · 3 comments
Closed

Java companion file handling broken in new Eclipse #1987

ripla opened this issue Jan 4, 2019 · 3 comments
Assignees
@ripla @anssit
Labels
bug V8
Milestone
4.1.1

Comments

@ripla
Copy link
Contributor

ripla commented Jan 4, 2019

Steps to reproduce

  1. Install Eclipse 2018-12 + Designer 4.1
  2. Import FW8 project
  3. Create a new FW design

Actual behavior

Design created without a companion file, with the exception:

java.lang.NoClassDefFoundError: org/eclipse/jdt/internal/corext/codemanipulation/StubUtility
	at com.vaadin.designer2.eclipse.java.ComponentJavaModel.formatJavaClass(ComponentJavaModel.java:268)
	at com.vaadin.designer2.eclipse.java.ComponentJavaModel.createJavaClassFromRoot(ComponentJavaModel.java:177)
	at com.vaadin.designer2.eclipse.wizards.NewDesignWizardPage.createJavaFile(NewDesignWizardPage.java:289)

Wizard stays open.

Expected behavior

Companion file created normally.

IDE, Designer and OS version

Eclipse 2018-12, Designer 4.1, macOS

Note

Affects all Java companion file operations, e.g. when saving an existing design.
@ripla
Copy link
Contributor Author

ripla commented Jan 4, 2019

Originally in #1986

@ripla ripla mentioned this issue Jan 4, 2019
Closed
@ripla ripla added the backlog label Jan 4, 2019
@ripla ripla self-assigned this Jan 4, 2019
@anssit anssit self-assigned this Jan 7, 2019
@ripla ripla added this to the 4.1.1 milestone Jan 15, 2019
@szolo szolo closed this as completed Jan 16, 2019
@akio4800
Copy link

thank you for the fix

@AlfredoDaAs
Copy link

AlfredoDaAs commented Feb 25, 2019 •
edited
Loading

I still have this issue and I have 4.2.1 version.

Eclipse 2018-12, Designer 4.2.1, Windows 10

@AlfredoDaAs AlfredoDaAs mentioned this issue Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripla ripla

@anssit anssit

Labels
bug V8
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
5 participants
@ripla @akio4800 @szolo @AlfredoDaAs @anssit