Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh paper when editing data binding #1801

Closed
ripla opened this issue Jun 20, 2018 · 1 comment
Closed

Refresh paper when editing data binding #1801

ripla opened this issue Jun 20, 2018 · 1 comment
Assignees
Milestone

Comments

@ripla
Copy link
Contributor

ripla commented Jun 20, 2018

Only refresh the edited component when changing data binding properties, not the whole browser.

Timebox: 4h

@szolo szolo assigned szolo and unassigned szolo Jul 18, 2018
@szolo
Copy link
Contributor

szolo commented Jul 19, 2018

@ripla Right now we explicitly reload embedded browser in 3 cases:

  1. If template was changed from the text editor.
  2. Is shared-styles file content was changed.
  3. If property change contains data binding.

In all 3 occasions we can reload only iframe wrapper, since they only affect it. Created a PR for it.

@tanbt tanbt self-assigned this Jul 19, 2018
@szolo szolo added this to the 3.0.6 milestone Jul 25, 2018
@szolo szolo closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants