Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show selection without modifying element #1690

Closed
ripla opened this issue Apr 11, 2018 · 2 comments
Closed

Show selection without modifying element #1690

ripla opened this issue Apr 11, 2018 · 2 comments
Assignees
Milestone

Comments

@ripla
Copy link
Contributor

ripla commented Apr 11, 2018

Currently selection relies on setting the CSS outline style and adding extra elements to DOM. To avoid the risk of breaking the user's designs the Designer must be able to

  • show selection outline without actually modifying anything
  • show selection outline without clipping it on the Paper edge
@ripla
Copy link
Contributor Author

ripla commented Jan 10, 2019

And check the actual CSS definition from Tuomas.

@tanbt tanbt self-assigned this Jan 11, 2019
@mjvesa mjvesa self-assigned this Jan 14, 2019
@tanbt
Copy link
Contributor

tanbt commented Jan 16, 2019

New design:
https://www.figma.com/file/Y6W4r0LNKZm2QXOEeRtEVVeb/Designer-Panels-Iteration?node-id=608%3A0

CSS from Tuomas:

.selector {
  box-shadow: inset 0 0 1px 1px #4C4C4D,
    inset 0 0 2px 2px rgba(255, 255, 255, 0.7),
    0 0 1px 1px rgba(255, 255, 255, 0.9) ;
}

@szolo szolo assigned szolo and unassigned mjvesa Jan 21, 2019
@szolo szolo added this to the 4.2.0 milestone Jan 31, 2019
@szolo szolo closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants